-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logos block to content page #337
Add logos block to content page #337
Conversation
This sounds like a perfect opportunity to get this onto |
@zerolab I sent Ben and Ian a short walkthrough of the design from my local machine. They approved it, so I think we can proceed to production. But I'm okay with testing on staging first if that's your preference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Changes to the blocks look good to me, just a minor issue with the spacing
@@ -4,11 +4,11 @@ | |||
position: relative; | |||
|
|||
&__heading { | |||
margin-bottom: 20px; | |||
margin-bottom: 80px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted a commit that sets the margin to 60px
for all views. Please let me know if there's anything else I should fix.
We need some small adjustments to the Logos block and to the blocks available on the Content page to create a suitable MVP design for the "Who Uses Wagtail" page.
This PR makes the Logos block available on the Content page type and provides an optional heading that can be used to organise the logos.
Ben E and Ian B from Torchbox want to review the design a bit before we proceed with merging, so I'm submitting this PR as a draft for now.