Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing comparison table accessibility issues (#435). Fix #318 #435

Merged
merged 7 commits into from
Feb 25, 2024
Merged

Fixing comparison table accessibility issues (#435). Fix #318 #435

merged 7 commits into from
Feb 25, 2024

Conversation

shyusu4
Copy link
Member

@shyusu4 shyusu4 commented Oct 27, 2023 •
edited

Fixes #318

@shyusu4 shyusu4 changed the title Fixing comparison table accessibility issues Fixing comparison table and cancel icon accessibility issues Oct 29, 2023
@shyusu4 shyusu4 marked this pull request as ready for review October 29, 2023 18:24
@Scotchester Scotchester self-requested a review December 19, 2023 14:18
@shyusu4 shyusu4 changed the title Fixing comparison table and cancel icon accessibility issues Fixing comparison table accessibility issues Feb 21, 2024
thibaudcolas
thibaudcolas approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking and working great, thank you @shyusu4!

@thibaudcolas thibaudcolas added bug Something isn't working accessibility labels Feb 25, 2024
@thibaudcolas thibaudcolas changed the title Fixing comparison table accessibility issues Fixing comparison table accessibility issues (#435). Fix #318 Feb 25, 2024
@thibaudcolas thibaudcolas merged commit 4fab0e2 into wagtail:main Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

@Scotchester Scotchester Awaiting requested review from Scotchester

Assignees
No one assigned
Labels
accessibility bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comparison table accessibility issues
2 participants
@shyusu4 @thibaudcolas