Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing comparison table accessibility issues (#435). Fix #318 #435

Merged
merged 7 commits into from
Feb 25, 2024
Merged

Fixing comparison table accessibility issues (#435). Fix #318 #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e5b252
Update markup for comparison table
shyusu4 Oct 27, 2023
7c71048
Remove color change on hover for modal cancel icons
shyusu4 Oct 29, 2023
bb8c357
Remove color change for mobile header
shyusu4 Oct 29, 2023
2987b1c
Merge branch 'wagtail:main' into fix/comparison-table-accessibility
shyusu4 Nov 27, 2023
c1d933f
Merge branch 'main' of github.com:shyusu4/wagtail.org into fix/compar…
shyusu4 Feb 21, 2024
feada0a
Update previous comparison table fix
shyusu4 Feb 21, 2024
5e00332
Revert icons style changes
shyusu4 Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 14 additions & 4 deletions ...lates/patterns/components/streamfields/comparison_table_block/comparison_table_block.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,27 @@
<thead>
<tr>
{% for col in value.comparison_table.columns %}
<th>{{ col.heading }}</th>
{% if col.heading %}
<th scope="col">{{ col.heading }}</th>
{% else %}
<td></td>
{% endif %}
{% endfor %}
</tr>
</thead>
<tbody>
{% endif %}
<tr>
{% for block in row %}
<td>
{% include_block block %}
</td>
{% if forloop.first %}
<th scope="row">
{{ block }}
</th>
{% else %}
<td>
{% include_block block %}
</td>
{% endif %}
{% endfor %}
</tr>
{% endfor %}
Expand Down
23 changes: 12 additions & 11 deletions wagtailio/static/sass/components/_comparison-table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,6 @@
grid-column: 2 / span 5;
}

td:first-child {
font-weight: $weight--bold;
width: 150px;

@include media-query(large) {
width: 250px
}
}

tbody {
grid-column: 2 / span 2;
grid-gap: 20px;
Expand All @@ -34,14 +25,24 @@
grid-column: 2 / span 5;
}

th {
// stylelint-disable-next-line declaration-property-value-allowed-list
text-align: left;
font-weight: $weight--bold;
width: 150px;

@include media-query(large) {
width: 250px
}
}

> tr:last-child {
td {
td, th {
border: unset;
}
}
}


td,
th {
padding: 20px 20px 20px 0;
Expand Down