Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page Links to Blog Pagination #450

Closed
wants to merge 1 commit into from

Conversation

SurajSanap
Copy link

@SurajSanap SurajSanap commented Jan 8, 2024

Worked on Issue #349,

Changes:

  1. Enclosed the pagination links within a
    with the class "pagination."
  2. Checked if there are more than one page before rendering the pagination links.
  3. Used {% if posts.paginator.num_pages > 1 %} to conditionally display pagination links.
  4. Moved the existing pagination code into the new
    block.
  5. Updated the first and last page links to include the correct page numbers.

Related Issue:
This pull request addresses Issue #349.

@thibaudcolas
Copy link
Member

@SurajSanap I think there’s a fundamental misunderstanding about what #349 is about here? None of the changes you say you did will have any impact on the issue at hand, and the template you edited isn’t even actively used on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants