Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.9rc1 regression in Block.render() #3346

Closed
mvantellingen opened this issue Feb 8, 2017 · 1 comment
Closed

1.9rc1 regression in Block.render() #3346

mvantellingen opened this issue Feb 8, 2017 · 1 comment
Milestone
1.9

Comments

@mvantellingen
Copy link
Member

The Block.render() (see

wagtail/wagtail/wagtailcore/blocks/base.py

Line 229 in 827149f

def render(self, value, context=None):
) accepts an optional context however a few lines below (

wagtail/wagtail/wagtailcore/blocks/base.py

Line 250 in 827149f

new_context.update(self.get_context(value))
) it is assumed that it is a dictionary.

We hit this issue since we implemented a get_context() override on a subclass of a blocks.StructBlock. Adding the parent_context kwarg and passing it down works the issue.

cc @mikedebock
mvantellingen added a commit to mvantellingen/wagtail that referenced this issue Feb 8, 2017
@mvantellingen
Fix a regression when overriding Block.get_context()
72c145a 
If ``Block.get_context()`` was overriden without accepting the
``parent_context`` kwarg the fallback handling threw an exception if
``context`` was None.

See wagtail#3346
@mvantellingen mvantellingen mentioned this issue Feb 8, 2017
Closed
@gasman gasman added this to the 1.9 milestone Feb 8, 2017
gasman pushed a commit that referenced this issue Feb 8, 2017
@mvantellingen @gasman
Fix a regression when overriding Block.get_context()
23890a0 
If ``Block.get_context()`` was overriden without accepting the
``parent_context`` kwarg the fallback handling threw an exception if
``context`` was None.

See #3346
gasman pushed a commit that referenced this issue Feb 8, 2017
@mvantellingen @gasman
Fix a regression when overriding Block.get_context()
3c8b43f 
If ``Block.get_context()`` was overriden without accepting the
``parent_context`` kwarg the fallback handling threw an exception if
``context`` was None.

See #3346
@gasman
Copy link
Collaborator

gasman commented Feb 8, 2017

Fixed in #3347

@gasman gasman closed this as completed Feb 8, 2017
trumpet2012 pushed a commit to morris-tech/wagtail that referenced this issue Feb 21, 2017
@mvantellingen @trumpet2012
Fix a regression when overriding Block.get_context()
489bc81 
If ``Block.get_context()`` was overriden without accepting the
``parent_context`` kwarg the fallback handling threw an exception if
``context`` was None.

See wagtail#3346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
2 participants
@gasman @mvantellingen