Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Chooser with Populate Title #7508

Closed
aliceni opened this issue Sep 9, 2021 · 5 comments · Fixed by #7579
Closed

Document Chooser with Populate Title #7508

aliceni opened this issue Sep 9, 2021 · 5 comments · Fixed by #7579
Labels
good first issue Hacktoberfest type:Enhancement

Comments

@aliceni
Copy link

aliceni commented Sep 9, 2021

Hi, I found that Document Chooser cannot populate the updated file title but Image Chooser does.
I think its good to add this feature and its not hard to implement it because the function already exists in image-chooser-modal.js
@zerolab
Copy link
Contributor

zerolab commented Sep 9, 2021

The relevant bits in the image chooser code are:

https://github.com/wagtail/wagtail/blob/main/wagtail/images/static_src/wagtailimages/js/image-chooser-modal.js#L116-L130

@akshay-kapase
Copy link

Is this already done?

@zerolab
Copy link
Contributor

zerolab commented Sep 19, 2021

@akshay-kapase no. Feel free to pick this up.

@Vruttant
Copy link

Hi, Can I work on this issue?

@lb-
Copy link
Member

lb- commented Sep 30, 2021

FYI, #7534 enhances the image title population with an override function, it might be good to copy this approach for the document files.

See also #4945 for context

@lb- lb- mentioned this issue Sep 30, 2021
Closed
lb- added a commit to lb-/wagtail that referenced this issue Oct 7, 2021
@lb-
add ability to customise the pre-filled document title
ae41fe3 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
@lb- lb- mentioned this issue Oct 7, 2021
Merged
lb- added a commit to lb-/wagtail that referenced this issue Oct 7, 2021
@lb-
add ability to customise the pre-filled document title
c9be234 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
lb- added a commit to lb-/wagtail that referenced this issue Oct 14, 2021
@lb-
add ability to customise the pre-filled document title
f4158fe 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
lb- added a commit to lb-/wagtail that referenced this issue Oct 14, 2021
@lb-
add ability to customise the pre-filled document title
5ded88c 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
lb- added a commit to lb-/wagtail that referenced this issue Oct 14, 2021
@lb-
add ability to customise the pre-filled document title
c04f784 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
lb- added a commit to lb-/wagtail that referenced this issue Oct 14, 2021
@lb-
add ability to customise the pre-filled document title
9433e28 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
lb- added a commit to lb-/wagtail that referenced this issue Oct 15, 2021
@lb-
add ability to customise the pre-filled document title
283e2e4 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
- update image docs for same behaviour to be more readable
lb- added a commit to lb-/wagtail that referenced this issue Oct 15, 2021
@lb-
add ability to customise the pre-filled document title
fa25d21 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes wagtail#7508
- see also wagtail#4945
- update image docs for same behaviour to be more readable
@lb- lb- closed this as completed in #7579 Oct 15, 2021
lb- added a commit that referenced this issue Oct 15, 2021
@lb-
add ability to customise the pre-filled document title
307d012 
- leveraging a custom DOM event provides the ability to update the title before being added to the form
- add documentation
- fixes #7508
- see also #4945
- update image docs for same behaviour to be more readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Hacktoberfest type:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ability to customise the pre-filled document title lb-/wagtail
5 participants
@zerolab @lb- @akshay-kapase @aliceni @Vruttant