AVIF support for wagtail #10657
Merged
AVIF support for wagtail #10657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://salty-ivyavif-support-bhqxa.squash.io |
zerolab
requested changes
Jul 10, 2023
There was a problem hiding this comment.
This is a solid start, @salty-ivy.
Left a number of suggestions
|
typo at. |
zerolab
reviewed
Jul 13, 2023
zerolab
reviewed
Jul 13, 2023
zerolab
reviewed
Jul 13, 2023
zerolab
reviewed
Jul 13, 2023
zerolab
reviewed
Jul 13, 2023
zerolab
reviewed
Jul 13, 2023
zerolab
added a commit
to salty-ivy/wagtail
that referenced
this pull request
Jul 13, 2023
zerolab
added a commit
to salty-ivy/wagtail
that referenced
this pull request
Jul 13, 2023
zerolab
added a commit
to salty-ivy/wagtail
that referenced
this pull request
Jul 13, 2023
zerolab
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
LGTM. Thank you @salty-ivy
This currently depends on a decision on #10676 as Willow 1.6 drops Python 3.7
| @@ -36,13 +36,19 @@ The `boost` option on `SearchField`, to increase the ranking of search results t | |||
|
|
|||
| ### Extend Stimulus adoption | |||
|
|
|||
| As part of tackling Wagtail’s technical debt and improving [CSP compatibility]([Title](https://github.com/wagtail/wagtail/issues/1288)), we have continued extending our usage of Stimulus, based on the plans laid out in [RFC 78: Adopt Stimulus](https://github.com/wagtail/rfcs/pull/78). | |||
| As part of tackling Wagtail’s technical debt and improving [CSP compatibility](https://github.com/wagtail/wagtail/issues/1288), we have continued extending our usage of Stimulus, based on the plans laid out in [RFC 78: Adopt Stimulus](https://github.com/wagtail/rfcs/pull/78). | |||
There was a problem hiding this comment.
🤦 I have disabled my "smart link paste" IDE feature, thanks for catching this.
thibaudcolas
pushed a commit
to salty-ivy/wagtail
that referenced
this pull request
Jul 14, 2023
thibaudcolas
force-pushed
the
avif-support
branch
from
63d116d
to
5c96a13
Compare
Co-Authored-By: Aman Pandey <74553951+salty-ivy@users.noreply.github.com>
Co-Authored-By: Aman Pandey <74553951+salty-ivy@users.noreply.github.com>
This is the value most used, and is the default in Willow too Co-Authored-By: Aman Pandey <74553951+salty-ivy@users.noreply.github.com>
thibaudcolas
force-pushed
the
avif-support
branch
from
5c96a13
to
b3649ed
Compare
|
And it’s in! I can’t think of anything better to end the week on
|
thibaudcolas
added
type:Enhancement
component:Images
GSOC
|
It was amazing bringing this in, special thanks to @zerolab |
|
Awesome stuff @salty-ivy and all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10486 (WIP)
Wagtail Counter part to support
AVIFWillow counter part
Issue: wagtail/Willow#111
PR: wagtail/Willow#115
Cc: @mrchrisadams @thibaudcolas @zerolab @laymonage
make lintfrom the Wagtail root.