Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update universal listings & UI table unit tests to be more robust #11724

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

lb-
Copy link
Member

@lb- lb- commented Mar 4, 2024

Relates to #11717 - Ensure that tests checking for th/td scope the checks to specific tables

We have a few unit tests that are counting th/td but currently these are not scoped to specific tables in the HTML. This means that any shared addition of tables will break these tests.

I have scoped the selectors to the elements that are intended to be tested, also making these tests more robust with mapping to the id so we know where these elements should be contained.

@lb- lb- added type:Cleanup/Optimisation component:Universal listings Including page listings, model listings and filtering. labels Mar 4, 2024
@lb- lb- requested a review from laymonage March 4, 2024 21:19
Copy link

squash-labs bot commented Mar 4, 2024

Manage this branch in Squash

Test this branch here: https://lb-fixmore-robust-unit-tests-t-s7xtd.squash.io

Copy link
Member

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This and #11725 are simple enough so I'll just merge via GitHub without release notes. Feel free to add release notes afterwards if you want, though.

@laymonage laymonage merged commit 269a0e4 into wagtail:main Mar 5, 2024
18 checks passed
@lb- lb- deleted the fix/more-robust-unit-tests-th-td branch March 5, 2024 22:15
@lb-
Copy link
Member Author

lb- commented Mar 5, 2024

Thanks @laymonage no need for a changelog for this and the other unit test. They are small changes that just help enable other items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Universal listings Including page listings, model listings and filtering. type:Cleanup/Optimisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants