Ensure unit tests for preview links are more robust #11725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lb-
commented
Mar 4, 2024
lb-
commented
- Relates to Add a basic keyboard shortcuts overview dialog #11717
- The word "Preview" can exist in multiple locations, especially for new code
- Instead of checking the word preview exists or does not exist, use Soup to check for the link specifically
- The word "Preview" can exist in multiple locations, especially for new code - Instead of checking the word preview exists or does not exist, use Soup to check for the link specifically
lb-
added
type:Cleanup/Optimisation
component:Preview
Manage this branch in SquashTest this branch here: https://lb-fixmore-robust-preview-link-2astu.squash.io |
laymonage
approved these changes
Mar 5, 2024
|
Nice to see my work from #10708 being of use here ❤️ |
|
Thanks @laymonage and yes, @Stormheg - having the helpers for using Soup makes it so much easier. It's almost like writing a Jest test ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.