Add Slovak character map for JS slug generation #4897
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porting of Django PR wagtail#9325, which fixes Django ticket #28768. These changes were made in Django 2.1. This adds support for certain Slovak characters when auto-generating slugs for new pages. This logic is only triggered if settings.WAGTAIL_ALLOW_UNICODE_SLUGS is set to False; see http://docs.wagtail.io/en/v2.1.1/advanced_topics/settings.html#unicode-page-slugs To test, create a new page and enter a title like "Vŕba". The page's slug field will be automatically set to "vrba". In the previous behavior, this would instead be automatically set to "vba". django/django#9325 https://code.djangoproject.com/ticket/28768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting of Django PR #9325, which fixes Django ticket #28768. These changes were made in Django 2.1.
This adds support for certain Slovak characters when auto-generating slugs for new pages. This logic is only triggered if
settings.WAGTAIL_ALLOW_UNICODE_SLUGSis set toFalse.To test, create a new page and enter a title like "Vŕba". The page's slug field will be automatically set to "vrba". In the previous behavior, this would instead be automatically set to "vba".