Redirect to collection listing after editing/deleting an item from it #7810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://tijani-diafeaturecollection-re-t7n7q.squash.io |
jacobtoppm
requested changes
Jan 6, 2022
wagtail/documents/views/documents.py
Outdated
| edit_url = reverse('wagtaildocs:edit', args=(doc.id,)) | ||
| redirect_url = 'wagtaildocs:index' | ||
| if next_url: | ||
| edit_url += "?" + urlencode({"next": next_url}) |
There was a problem hiding this comment.
Nitpick: You can probably use an f-string or similar instead of concatenation here
wagtail/images/views/images.py
Outdated
| collection_id = self.request.GET.get('collection_id') | ||
| if collection_id: | ||
| try: | ||
| self.current_collection = Collection.objects.get(id=collection_id) | ||
| images = images.filter(collection=self.current_collection) | ||
| next_url = reverse('wagtailimages:index') + "?" + urlencode({"collection_id": collection_id}) |
There was a problem hiding this comment.
Do we need this? Shouldn't we just use the current url, so we get tags (for instance) as well?
There was a problem hiding this comment.
Sure! I've updated it to use the current url so we don't lose information.
lb-
added
component:Images
status:Needs Work
component:Collections
and removed
component:Images
labels
Tijani-Dia
force-pushed
the
feature/collection-redirect
branch
from
d176101
to
1e14fe0
Compare
Tijani-Dia
changed the title
Tijani-Dia
force-pushed
the
feature/collection-redirect
branch
from
545ebd9
to
e4ab9e8
Compare
|
Merged in bafb435 |
This was referenced Nov 22, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user selects a collection to browse in the admin and opens a file to make some changes to it, on save, the admin browser defaults back to a default view of documents/images instead of staying on the collection and the page of the collection the users was on when they clicked on the file to make changes.
The goal of this PR is to make the view remember the collection users were exploring before editing one item from that collection.