Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch slim sidebar to be on by default #7864

Merged
merged 9 commits into from
Jan 21, 2022

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Jan 14, 2022

Changes our settings so the slim sidebar is on by default. Fixes #5337. This includes:

  • Changing how the feature flag works so it’s opt-out rather than opt-in, with a new WAGTAIL_SLIM_SIDEBAR setting to opt out.
  • Updating the documentation to match what the slim sidebar provides.
  • Updating the release notes, with upgrade consideration notes for anything that’s no longer supported.
  • Updating our tests which relied on implementation details of the sidebar.

For this last point, I decided to refactor how the sidebar’s data is transferred client-side a bit, moving to a separate JSON script tag so it’s more readable when troubleshooting and when used in tests.

I’ve also updated the RemovedInWagtail217Warning I had added, as indeed upon checking with our deprecation policy it should be RemovedInWagtail218Warning.


  • Do the tests still pass? (https://docs.wagtail.io/en/latest/contributing/developing.html#testing)
  • Does the code comply with the style guide? (Run make lint from the Wagtail root)
  • For Python changes: Have you added tests to cover the new/fixed behaviour?
  • For front-end changes: Did you test on all of Wagtail’s supported environments?
    • Please list the exact browser and operating system versions you tested. Chrome, Safari macOS
    • Please list which assistive technologies you tested. N/A
  • For new features: Has the documentation been updated accordingly?

@squash-labs
Copy link

squash-labs bot commented Jan 14, 2022

Manage this branch in Squash

Test this branch here: https://thibaudcolasfeaturesidebar-def-xmhdz.squash.io

@thibaudcolas thibaudcolas force-pushed the feature/sidebar-default branch 2 times, most recently from aed9d59 to f50511e Compare January 14, 2022 17:03
@thibaudcolas thibaudcolas added this to the 2.16 milestone Jan 14, 2022
@thibaudcolas thibaudcolas changed the title WIP – slim sidebar on by default Switch slim sidebar to be on by default Jan 14, 2022
Copy link
Contributor

@kaedroho kaedroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

@gasman gasman merged commit 20a7d1e into wagtail:main Jan 21, 2022
@thibaudcolas thibaudcolas deleted the feature/sidebar-default branch January 21, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement focus management in main menu
3 participants