-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch slim sidebar to be on by default #7864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://thibaudcolasfeaturesidebar-def-xmhdz.squash.io |
gasman
reviewed
Jan 14, 2022
thibaudcolas
force-pushed
the
feature/sidebar-default
branch
2 times, most recently
from
January 14, 2022 17:03
aed9d59
to
f50511e
Compare
thibaudcolas
changed the title
WIP – slim sidebar on by default
Switch slim sidebar to be on by default
Jan 14, 2022
kaedroho
reviewed
Jan 19, 2022
kaedroho
reviewed
Jan 19, 2022
…PERIMENTAL_FEATURES
…ementation details
thibaudcolas
force-pushed
the
feature/sidebar-default
branch
from
January 21, 2022 08:29
f50511e
to
6ee8041
Compare
kaedroho
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes our settings so the slim sidebar is on by default. Fixes #5337. This includes:
WAGTAIL_SLIM_SIDEBAR
setting to opt out.For this last point, I decided to refactor how the sidebar’s data is transferred client-side a bit, moving to a separate JSON script tag so it’s more readable when troubleshooting and when used in tests.
I’ve also updated the
RemovedInWagtail217Warning
I had added, as indeed upon checking with our deprecation policy it should beRemovedInWagtail218Warning
.make lint
from the Wagtail root)