-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail packaging fixes #8030
Wagtail packaging fixes #8030
Conversation
Manage this branch in SquashTest this branch here: https://thibaudcolaschorepackaging-zewg6.squash.io |
global-exclude *.py[co] | ||
global-exclude .gitignore | ||
global-exclude wagtail-icomoon.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: given wagtail-icomoon lives under wagtail/admin/static_src/wagtailadmin/fonts
will it not be excluded via prune **/statics_src
? or is it copied to static by the front-end tooling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is currently being copied at wagtail/admin/static/wagtailadmin/fonts/wagtail-icomoon.json
. I don’t know by what or why though 😅 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This contains two unrelated changes:
npm run dist
(now removed) tonpm run build
I grouped them together basically because the testing steps are identical: run
python setup.py sdist bdist_wheel
. Make sure torm -rf build *.egg-info dist
so setuptools reliably determines which files are to be included without any caching.Before/after on file size:
This is a pretty small difference but IMHO still worthwhile.
Here are the files / folders that will no longer be included, based on diffing the wheel’s contents (output of `find before/after: