Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering progress preview with tev #142

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

iXialumy
Copy link

Hey @wahn ,
It finally happened.
I found time again to work on communication with tev.
This definitely is just a barely working prototype, but it can actually display progress while rendering.
It is just full of unwraps that should be handled properly and many things are done in a very un-rust way, but we have something that works somewhat.
At the moment the values sent to tev are not scaled properly and I would love to work on fixing and improving from here on with you together if you can find time.

@iXialumy iXialumy changed the title MVP - Rendering progress preview with tev Rendering progress preview with tev Nov 27, 2022
Definitely very hacky up at this point
@wahn
Copy link
Owner

wahn commented Sep 4, 2023

Hey @iXialumy,
Sorry for the long delay. I looked at your pull request and because the main development happens now on sourcehut I created a tev branch there and checked in a slightly modified version of your PR. I don't know how to give you credit for your work (so that's it's visible here at GitHub), but I wanted to let you know that I finally started to integrate your PR into one of the next versions of rs_pbrt!
Thanks,
Jan

@wahn
Copy link
Owner

wahn commented Sep 5, 2023

See https://www.janwalter.org/rnd/blog/rnd-pbrt-tev-001/ for a start ...

@iXialumy
Copy link
Author

Hey @wahn,
No problem for the delay, I took a long time too.
I think we should discuss a few things before merging this pr first, because I think the logic is not at the right place at the moment.
Currently it is in the integrator, but I feel like this is not the best place for the architecture we currently have.
On the other hand I am not sure I understand the architecture well enough for that yet.

We can work on sourcehut too, but I don't know the workflow of communication and working together on an issue yet.
Let me know if you would be open to looking into that with me.
Thanks,
iXialumy

@wahn
Copy link
Owner

wahn commented Sep 20, 2023

I'm not that familiar with the sourcehut workflow yet, but there is a mailing list to discuss rs-pbrt related things:
https://lists.sr.ht/~wahn/rs-pbrt-discuss
I think your email client has to be configured to use plain text emails, but that should be all ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants