[v2, windows] Fix WebView2 minimum runtime version check #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise 4294967295 will be returned instead of -1 and the minimum version check can't detect an older version. So an older version than the minimum might be used and will result in AccessViolationExceptions.
The Webview2Loader.dll are already at version 1.0.992.28 for all platforms.
leaanthony
reviewed
Jun 16, 2022
| @@ -43,16 +42,16 @@ func CompareBrowserVersions(v1 string, v2 string) (int, error) { | |||
| return 0, err | |||
| } | |||
|
|
|||
| var result int | |||
| var result int32 | |||
leaanthony
approved these changes
Jun 16, 2022
|
Thanks for merging |
|
Thanks for raising the PR! 👍👍 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.