[Windows] Add Suspend/Resume callback support #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4e451d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af557d89.wails-website.pages.dev |
| Branch Preview URL: | https://feature-windows-suspend-resu.wails-website.pages.dev |
stffabi
approved these changes
Jun 21, 2022
Collaborator
stffabi
left a comment
stffabi
left a comment
There was a problem hiding this comment.
LGTM, I've just added a minor comment.
| isDarkMode bool | ||
| isActive bool | ||
| hasBeenShown bool | ||
| OnSuspend func() |
Collaborator
There was a problem hiding this comment.
Should we make OnSuspend and OnResume private?
Member
Author
There was a problem hiding this comment.
That's a great point. I think for now it's ok as Window is an internal struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these so that an application developer can choose to do things like teardown/standup network connections on suspend/resume.