Skip to content

[assetserver] Add support for range requests if the fs.FS provides an io.Seeker - #2091

Merged
stffabi merged 1 commit into
wailsapp:masterfrom
stffabi:feature/assetserver-range-requests
Nov 14, 2022
Merged

stffabi merged 1 commit into
wailsapp:masterfrom
stffabi:feature/assetserver-range-requests

Conversation

@stffabi

@stffabi stffabi commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

This allows streaming audio and videos with range requests if the platform webview supports it.

… io.Seeker

This allows streaming audio and videos with range requests if the
platform webview supports it.
@stffabi
stffabi requested a review from leaanthony November 14, 2022 16:36
@stffabi
stffabi enabled auto-merge (squash) November 14, 2022 16:37
@leaanthony

Copy link
Copy Markdown
Member

Awesome addition! I'm wondering if there's an easy way to demonstrate this that I could make and put in the examples directory.

@stffabi
stffabi merged commit 177d904 into wailsapp:master Nov 14, 2022
@stffabi
stffabi deleted the feature/assetserver-range-requests branch November 15, 2022 07:45
@stffabi

stffabi commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for merging 🙏

Yeah we could add an example, do we need to enable LFS on the repo to add the media files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants