[assetserver] Add support for range requests if the fs.FS provides an io.Seeker #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… io.Seeker This allows streaming audio and videos with range requests if the platform webview supports it.
|
Awesome addition! I'm wondering if there's an easy way to demonstrate this that I could make and put in the examples directory. |
leaanthony
approved these changes
Nov 14, 2022
|
Thanks for merging 🙏 Yeah we could add an example, do we need to enable LFS on the repo to add the media files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows streaming audio and videos with range requests if the platform webview supports it.