Devtools hotkey

[leaanthony]

Description

This PR adds an F12 hotkey shortcut to open the devtools window, whenever the app is built with the devtools flag.
Not sure if this could be an issue for signed apps... I don't think it is...

Fixes #2908

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Create a new project, build with wails build and check F12 does nothing. Build with wails build -devtools and press F12.

• Windows
• macOS
• Linux

Checklist:

• I have updated website/src/pages/changelog.mdx with details of this PR
• My code follows the general coding style of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	6e05fab
Status:	⚡️  Build in progress...

View logs

[mmghv]

Works as expected on windows.

Now that F12 opens the devtools, maybe -devtools shouldn't enable the default contextmenu? so only EnableDefaultContextMenu option enables it in production.

[leaanthony]

I'm open to discussion on this. The only edge case is Mac apps that want it enabled and want it on the appstore (does that combo even make sense???).

[mmghv]

Can't speak for Mac devs, but if I understand correctly there's no way around it if you want F12 or a runtime method to open it.

Honestly F12 makes a lot of sense and makes life easier, it also solves the default contextmenu problem because now you don't have to show it with -devtools.

[stffabi]

LGTM, should we also warn in build.go that private APIs are being used on macOS when build-tag devtools is used?

wails/v2/pkg/commands/build/build.go

Lines 351 to 353 in 3116c1a

	if options.Platform == "darwin" && options.Mode == Debug {
	pterm.Warning.Println("A darwin debug build contains private APIs, please don't distribute this build. Please use it only as a test build for testing and debug purposes.")
	}

[leaanthony]

I've changed the key combination to CTRL/CMD+SHIFT+F12 to make it less likely to clash with current bindings.

[leaanthony]

@mmghv - I've removed what I think is the right code to stop devtools enabling the default context menu. It looks like it was only enabled in Windows?

[mmghv]

I've removed what I think is the right code to stop devtools enabling the default context menu. It looks like it was only enabled in Windows?

No it exists in all platforms but each with it's own way, also what you changed disabled the default context-menu on windows in debug & dev, revert it and I'll do it along with some relevant docs changes in a separate PR after you merge this.

[mmghv]

This change disables the default context-menu on windows in dev & debug because f.devtools is enabled for -devtools, -debug and dev mode.

[leaanthony]

Will do tomorrow 👍

[leaanthony]

@mmghv - change reverted 👍