Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Devtools tag doesn't enable default context-menu #2923

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

mmghv
Copy link
Contributor

@mmghv mmghv commented Sep 19, 2023

Description

Now that -devtools tag adds a hotkey, it doesn't need to enable the default context-menu in production, so only the EnableDefaultContextMenu option enables it in production.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Isn't really considered a breaking change since it doesn't affect the core functionality of the application.

How Has This Been Tested?

When EnableDefaultContextMenu is false or not set:

command Devtools (CTRL/CMD+SHIFT+F12) Default context-menu (right-click inside an input)
wails build Not Available Not Available
wails build -devtools Available Not Available
wails build -debug Available Available Everywhere
wails dev Available Available Everywhere

When EnableDefaultContextMenu is true:

command Devtools (CTRL/CMD+SHIFT+F12) Default context-menu (right-click inside an input)
wails build Not Available Available (No inspect option)
wails build -devtools Available Available (with inspect option)
wails build -debug Available Available Everywhere
wails dev Available Available Everywhere
  • Windows
  • macOS
  • Linux

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mmghv
Copy link
Contributor Author

mmghv commented Sep 19, 2023

Tested on Linux, great news, the devtools can be opened with the hotkey while the default context-menu is disabled, contrary to my previous tests on Linux, so we could later add an option to disable the hotkey and expose a runtime method to open the devtools with a password or something (but the default context-menu have to be disabled then).

@leaanthony Please test on Mac when you have the time.

@mmghv mmghv marked this pull request as ready for review September 19, 2023 12:23
@leaanthony
Copy link
Member

Bah, any chance you could resolve conflicts and we'll get this in 👍

@mmghv
Copy link
Contributor Author

mmghv commented Sep 24, 2023

@leaanthony Done 👍
Please do a quick test on mac before merging

@leaanthony leaanthony self-requested a review September 25, 2023 09:24
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man! 🙏

@leaanthony leaanthony merged commit 3f9067c into wailsapp:master Sep 25, 2023
3 checks passed
@mmghv mmghv deleted the devtools-contextmenu branch September 25, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants