-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Rename AbsolutePosition()
to Position()
#3611
[v3] Rename AbsolutePosition()
to Position()
#3611
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
07a8b0f
to
40a8f58
Compare
Nice one @mmghv ! Exciting times! 🚀🚀🚀 |
Description
This is in preparation for the DPI work, where we will have methods for
physical
andlogical (DIP)
position, we currently haveabsolute
andrelative
position, when combined withphysical
andDIP
things will get messy and confusing for developers, so to simplify things, we will reduce the methods to the bare minimum and strip the default behavior methods of any adjectives, so by default,Position()
andSetPosition()
will be inDIP
(logical) coordinates and absolute (relative to the desktop origin), if the developer wants to specifically position relative to the current screen, he would useSetRelativePosition()
, in cases where there's only one monitor, it will be identical toSetPosition()
.P.S. Absolute position is the default and only available method in Tauri and Electron, since you can use it to position relative to the current screen once you get the screen coordinates.
Type of change
How Has This Been Tested?
Checklist:
website/src/pages/changelog.mdx
with details of this PR