Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub Actions #239

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Migrate CI to GitHub Actions #239

merged 3 commits into from
Mar 8, 2022

Conversation

petergoldstein
Copy link
Contributor

This PR migrates CI to GitHub actions. Linting is split out into a separate task from specs. Everything is green.

As pry-byebug is not compatible with Ruby 3.2 and beyond, it's been removed from the project so that ruby-head runs green.

An additional Code Climate id is required to get Code Climate working with the new setup.

Copy link
Owner

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @petergoldstein, that's very nice!

I added one comment, but I can do it myself in another commit. Also, it'd be nice to remove .travis.yml as part of this PR.

@petergoldstein
Copy link
Contributor Author

@waiting-for-dev I've removed .travis.yml and Ruby 2.6.

@waiting-for-dev waiting-for-dev merged commit e1102ee into waiting-for-dev:master Mar 8, 2022
@waiting-for-dev
Copy link
Owner

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants