Enable asymmetric algorithms #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Warden::JWTAuth` shipped a feature for Asymmetric algorithms which adds a configuration setting for `decoding_secret`. By default, this is setting is configured to use `secret` when it is not otherwise explicitly set. On first encounter and my limited testing, I thought the default behavior was not correctly working and submitted an issue on: waiting-for-dev/warden-jwt_auth#44 Upon further testing, however, it was clear the defaults were working as expected in that repository. The issue turned out to be that the configuration was being prematurely "cached" as nil before `secret` was ever set in devise-jwt. Before: Output of Devise::JWT.config ``` { secret: "keep-it-secret", ... } ``` Output of Warden::JWTAuth.config ``` { secret: "keep-it-secret", decoding_secret: nil, ... } ``` After: Output of Devise::JWT.config ``` { secret: "keep-it-secret", ... } ``` Output of Warden::JWTAuth.config ``` { secret: "keep-it-secret", decoding_secret: "keep-it-secret", ... } ``` I'm not entirely sure the purpose the `.to_h` was serving in `self.jwt`; however, all of the specs still pass without those lines, the configuration looks correct / yielding the expected settings, and testing against the app that prompted this deep dive is resolved with this change.
Warden::JWTAuth added support for asymmetric algorithms, allowing the specification of a separate decoding secret from the standard secret. This, along with the change from waiting-for-dev#250, fixes the "No verification key available" error as well as allows folks to use Devise::JWT with asymmetric algorithms if they so choose.
|
Many thanks! 🙌 |
|
Available on v0.10.0. Thanks again for your collaboration! |
Eric-Guo
added a commit
to thape-cn/oauth2id
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warden::JWTAuthadded support for asymmetric algorithms, allowing thespecification of a separate decoding secret from the standard secret.
This, along with the (included) change from #250, fixes the "No verification key
available" error as well as enables support to allow folks to use
Devise::JWTwith an algorithm of their choosing, including an asymmetric algorithm if they so choose.