Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for delayed tasks in LogQueue #32

Merged
merged 10 commits into from
Nov 18, 2013

Conversation

clementgarnier
Copy link
Contributor

No description provided.

@clementgarnier
Copy link
Contributor Author

Not sure why this test ("Feeder should it should "start at context position" in TestLogQueueFeeder) fails. A NullPointerException here means that the underlying iterator returned true on hasNext then null on next()

@clementgarnier
Copy link
Contributor Author

Got it, iterators created with Iterator.continually() always return true on hasNext, we just need to properly mock the reader.

@@ -82,4 +82,5 @@ object QueueResource {
val TaskToken = "token"
val TaskId = "id"
val TaskPriority = "priority"
val ScheduleTime = "scheduletime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskScheduleTime ?

* Expose delay instead of scheduleTime in API
* Expose delayedTasks as an Iterator[Task] in DelayedTaskIterator
* Few renamings
* Run Scalariform
@mlaflamm
Copy link
Contributor

+1

Conflicts:
	bwl-core/src/main/scala/com/wajam/bwl/Bwl.scala
	bwl-core/src/main/scala/com/wajam/bwl/queue/log/LogQueue.scala
	bwl-core/src/main/scala/com/wajam/bwl/queue/memory/MemoryQueue.scala
clementgarnier added a commit that referenced this pull request Nov 18, 2013
Add support for delayed tasks in LogQueue
@clementgarnier clementgarnier merged commit 717e8b3 into master Nov 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants