Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to getpwuid when HOME env var not set #547

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fallback to getpwuid when HOME env var not set #547

merged 1 commit into from
Sep 21, 2021

Conversation

alanhamlett
Copy link
Member

Let's see if this can detect the current user's home folder when $HOME env var is unset. Should fix wakatime/vscode-wakatime#238.

@alanhamlett alanhamlett mentioned this pull request Sep 17, 2021
Merged
@alanhamlett alanhamlett changed the title Enable building with CGO on POSIX platforms except Mac Fallback to getpwuid when HOME env var not set Sep 17, 2021
@alanhamlett alanhamlett force-pushed the bugfix/enable-cgo-linux branch 5 times, most recently from f64941e to 36f8511 Compare September 21, 2021 00:53
gandarez
gandarez requested changes Sep 21, 2021
View reviewed changes
Copy link
Member

@gandarez gandarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines of code might be changed to be more "Go style".

Makefile Outdated Show resolved Hide resolved
cmd/legacy/logfile/logfile.go Outdated Show resolved Hide resolved
pkg/api/transport_windows.go Show resolved Hide resolved
pkg/pwd/pwd_cgo.go Outdated Show resolved Hide resolved
pkg/pwd/pwd_cgo.go Outdated Show resolved Hide resolved
pkg/pwd/pwd_cgo.go Outdated Show resolved Hide resolved
pkg/pwd/pwd_test.go Outdated Show resolved Hide resolved
pkg/config/config.go Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@gandarez gandarez added the bug Something isn't working label Sep 21, 2021
gandarez
gandarez requested changes Sep 21, 2021
View reviewed changes
pkg/pwd/pwd_cgo.go Outdated Show resolved Hide resolved
gandarez
gandarez approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@gandarez gandarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alanhamlett alanhamlett merged commit f451c92 into develop Sep 21, 2021
@alanhamlett alanhamlett deleted the bugfix/enable-cgo-linux branch September 21, 2021 01:45
This was referenced Sep 21, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandarez gandarez gandarez approved these changes

Assignees

@alanhamlett alanhamlett

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alanhamlett @gandarez