chore: new filter tests #1552
Merged
chore: new filter tests #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…re/new-filter-tests
weboko
reviewed
Sep 11, 2023
| }); | ||
|
|
||
| it("Subscribe and receive messages via lightPush", async function () { | ||
| // Subscribe to the content topic and set callback for received messages. |
There was a problem hiding this comment.
It's good to have comments but to me it seems we can drop some of them sicne it is clear what's happening by the code.
There was a problem hiding this comment.
Agreed, will remove some of them :)
weboko
reviewed
Sep 11, 2023
| @@ -2,7 +2,9 @@ import { | |||
| createDecoder, | |||
There was a problem hiding this comment.
Amazing job! I have only one comment here - the file is huge now.
I propose to break it into some files under filter folder.
There was a problem hiding this comment.
Yes, makes sense, I'll create a folder with multiple files based on features:
- subscribe
- ping
- unsubscribe
- filterPush
- filterTestUtils
Makes sense?
weboko
approved these changes
Sep 12, 2023
|
@weboko thanks for the review! Can you also please merge it :) ? |
fbarbu15
added
the
E:End-to-end testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After reviewing the filter tests found the following problems:
Solution
Added PR with following fixes:
Notes
Subscribe and receive messages from multiple nwaku nodes