chore: new lightpush tests #1571
Conversation
size-limit report 📦
|
fbarbu15
added
the
E:End-to-end testing
…re/new-lightpush-tests
| @@ -0,0 +1,193 @@ | |||
| import { | |||
There was a problem hiding this comment.
nit: we can rename the file simply utils.ts since it's in tests/light-push already
| } | ||
| } | ||
|
|
||
| export async function runNodes( |
There was a problem hiding this comment.
we can probably generalise this as a util itself for a scope of all tests
| } | ||
| } | ||
|
|
||
| export function tearDownNodes(nwaku: NimGoNode, waku: LightNode): void { |
There was a problem hiding this comment.
generalise this for the entire tests scope as well
| @@ -0,0 +1,227 @@ | |||
| import { createEncoder, DefaultPubSubTopic } from "@waku/core"; | |||
There was a problem hiding this comment.
can rename file to index.spec.ts
| return this.list[index]; | ||
| } | ||
|
|
||
| async waitForMessages( |
There was a problem hiding this comment.
this can probably be generalised for the scope of all tests as well
There was a problem hiding this comment.
Added all message collection logic to src/message_collector.ts and made it work for both MessageRpcResponse and DecodedMessage
Thanks for the hint
…re/new-lightpush-tests
| } | ||
| } | ||
|
|
||
| export async function runNodes( |
There was a problem hiding this comment.
can we make this configurable to allow arbitrary number of waku and nwaku to be started with this?
something like:
runNodes(content, {nwaku: 3, jswaku: 1})
There was a problem hiding this comment.
we could but we would need to add lots of parameters to runNodes to make it trully generic
And looking at other tests/protocols, most of the have different setup needs
| export const messageText = "Light Push works!"; | ||
| export const messagePayload = { payload: utf8ToBytes(messageText) }; | ||
|
|
||
| export async function runNodes( |
There was a problem hiding this comment.
oh, all protocol tests would have their own version of runNodes?
There was a problem hiding this comment.
from what I saw, it's just filter and lightpush. The other protocols would not use similar setup-node code. That's why I didn't put it in a global util functions like the others.
And event between filter and lightpush the code is pretty different: different nwaku args, different createLightNode args, different waitForRemotePeer protocols.
I can merge them into one but not sure how much value that will add
Thank you! Can you please merge it? I don't have access |
Problem
Similar to #1552
Solution
Added PR with following fixes: