chore: increase max sub topic size to 100 #1791
Conversation
size-limit report 📦
|
| @@ -85,14 +85,14 @@ jobs: | |||
| node_with_go_waku_master: | |||
| uses: ./.github/workflows/test-node.yml | |||
| with: | |||
| nim_wakunode_image: wakuorg/go-waku:latest | |||
| nim_wakunode_image: harbor.status.im/wakuorg/go-waku:latest | |||
There was a problem hiding this comment.
@fbarbu15 why did you move it to different repo for the image?
There was a problem hiding this comment.
harbor.status.im is the official repo for the nwaku and gowaku images and from there they are replicated on docker hub
But the replication had issues in the past and docker hub images were outdated.
So for the interop testing project I was instructed to use the images from harbor.status.im because it's more likely for them to be up to date.
That's why I updated them on js-waku side as well
| @@ -219,11 +220,14 @@ describe("Waku Filter V2: Subscribe", function () { | |||
| }); | |||
| }); | |||
|
|
|||
| it("Subscribe to 30 topics at once and receives messages", async function () { | |||
| const topicCount = 30; | |||
| it("Subscribe to 100 topics at once and receives messages", async function () { | |||
There was a problem hiding this comment.
I think it is better to split this test in two: one for legacy versions of nwaku with testing 30 topics and another for 0.24.0 with 100 topics.
In this way it will be less misleading considering the name of the test.
Problem
Fixes failed test caused by this nwaku change
Updated deprecated master images for nwaku and go-waku
Merge only after above PR is merged