chore: split 100 topics tests in old and new behaviour #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarbu15
changed the title
size-limit report 📦
|
weboko
reviewed
Jan 19, 2024
| @@ -220,11 +220,14 @@ describe("Waku Filter V2: Subscribe", function () { | |||
| }); | |||
| }); | |||
|
|
|||
| it("Subscribe to 100 topics at once and receives messages", async function () { | |||
| let topicCount = 30; | |||
| it("Subscribe to 100 topics (new limit) at once and receives messages", async function () { | |||
There was a problem hiding this comment.
Should we make a todo to remove old tests?
Are there any other tests that might need to be changed/removed?
There was a problem hiding this comment.
Added TODO
No, only those tests are affected afaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the Subscribe to 100 topics into tests for old and new functionality and run only relevant tests (based on comment)