Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waku v2 Websocket support #434

Closed
5 tasks done
D4nte opened this issue Mar 24, 2021 · 10 comments · Fixed by #732
Closed
5 tasks done

Waku v2 Websocket support #434

D4nte opened this issue Mar 24, 2021 · 10 comments · Fixed by #732
Assignees
Labels
enhancement New feature or request

Comments

@D4nte
Copy link
Contributor

D4nte commented Mar 24, 2021

Problem

Currently, libp2p only supports websockets and webrtc in the browser. We decided to start with websockets.

As nim-waku is the intended waku full node, browser client needs a way to connect to nim-waku nodes.

Additionally, as described in waku-org/js-waku#50, the websocket connections needs to be wrapped in TLS. As modern browsers simply block insecure websocket connection within an https page.

My understanding is that the intent of nim-waku is to be ran by the community to run a network. Thus, it should be consider how one can easily deployed nim-waku with wss enabled (certificate generation, etc).

Acceptance criteria

  • Ensure nim-waku can be run with Websockets and connect with js-waku
  • Ensure this works with wss enabled
  • Deploy and test with test fleet
  • Relevant spec changes as a new capability for Waku (10/WAKU2: Define supported transports in spec vacp2p/rfc#458)
  • Add a basic tutorial to docs folder explaining how to setup a node with wss enabled (e.g. a couple of openssl command lines to generate an ip certificate).

References

@D4nte D4nte added enhancement New feature or request waku-v2 labels Mar 24, 2021
@jm-clius
Copy link
Contributor

I might be missing something, but it doesn't look like this is integrated in nim-libp2p yet?

Tracking issue there: vacp2p/nim-libp2p#407

@jm-clius jm-clius added the blocked This issue is blocked by some other work label Mar 24, 2021
@jm-clius
Copy link
Contributor

blocked-by vacp2p/nim-libp2p#407

@D4nte
Copy link
Contributor Author

D4nte commented Mar 25, 2021

Sorry about that, I jumped the gun!

@jm-clius
Copy link
Contributor

jm-clius commented Apr 7, 2021

Unassigning myself here for now to clean up some issues. Feel free to ping me once this is unblocked/becomes a priority.

@jm-clius jm-clius removed their assignment Apr 7, 2021
@D4nte
Copy link
Contributor Author

D4nte commented Apr 29, 2021

Please note I updated the description to include wss.

@oskarth oskarth added this to New in Deprecated: nwaku Jul 14, 2021
@oskarth oskarth moved this from New to Icebox in Deprecated: nwaku Jul 14, 2021
@D4nte D4nte changed the title Waku libp2p websocket support Websocket support Aug 31, 2021
@D4nte D4nte changed the title Websocket support Waku v2 Websocket support Aug 31, 2021
@D4nte
Copy link
Contributor Author

D4nte commented Sep 1, 2021

nim-libp2p is ready: vacp2p/nim-libp2p#407 (comment).

@D4nte D4nte removed the blocked This issue is blocked by some other work label Sep 1, 2021
@D4nte D4nte moved this from Icebox to New in Deprecated: nwaku Sep 1, 2021
@oskarth oskarth moved this from New to Icebox in Deprecated: nwaku Sep 6, 2021
@oskarth
Copy link
Contributor

oskarth commented Sep 6, 2021

Probably good for a new hire

@oskarth oskarth moved this from Icebox to Backlog in Deprecated: nwaku Sep 6, 2021
@rshiv rshiv self-assigned this Oct 4, 2021
@rshiv rshiv moved this from Backlog to In Progress in Deprecated: nwaku Oct 4, 2021
@rshiv rshiv linked a pull request Oct 6, 2021 that will close this issue
@rshiv rshiv closed this as completed in #732 Nov 2, 2021
Deprecated: nwaku automation moved this from In Progress to Done Nov 2, 2021
@rshiv rshiv moved this from Done to In Progress in Deprecated: nwaku Nov 2, 2021
@oskarth
Copy link
Contributor

oskarth commented Nov 3, 2021

@rshiv I think OP still has some open items for this to be closed.

Feel free to break out individual items into their own issues - in general the more granular (while still being useful on its own) the better

@oskarth oskarth reopened this Nov 3, 2021
@rshiv rshiv linked a pull request Nov 5, 2021 that will close this issue
@rshiv rshiv mentioned this issue Nov 5, 2021
@rshiv rshiv removed a link to a pull request Nov 5, 2021
@staheri14 staheri14 moved this from In Progress to Backlog in Deprecated: nwaku Nov 8, 2021
@staheri14 staheri14 moved this from Backlog to In Progress in Deprecated: nwaku Nov 8, 2021
@rshiv
Copy link
Contributor

rshiv commented Nov 17, 2021

All the task related to web-sockets is achieved including test in the fleets.
However, I want to mention an issue in websock which might cause the fleets to go unpredictable and crash for websocket address, status-im/nim-websock#79.

@D4nte Please review the changes and feel free to close the issue.

@D4nte
Copy link
Contributor Author

D4nte commented Nov 26, 2021

Awesome news. Yes, will review, tracking with waku-org/js-waku#327.
Will open new issues if I encounter any bug.

@D4nte D4nte closed this as completed Nov 26, 2021
Deprecated: nwaku automation moved this from In Progress to Done Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants