-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waku v2 Websocket support #434
Comments
I might be missing something, but it doesn't look like this is integrated in nim-libp2p yet? Tracking issue there: vacp2p/nim-libp2p#407 |
blocked-by vacp2p/nim-libp2p#407 |
Sorry about that, I jumped the gun! |
Unassigning myself here for now to clean up some issues. Feel free to ping me once this is unblocked/becomes a priority. |
Please note I updated the description to include wss. |
nim-libp2p is ready: vacp2p/nim-libp2p#407 (comment). |
Probably good for a new hire |
@rshiv I think OP still has some open items for this to be closed. Feel free to break out individual items into their own issues - in general the more granular (while still being useful on its own) the better |
All the task related to web-sockets is achieved including test in the fleets. @D4nte Please review the changes and feel free to close the issue. |
Awesome news. Yes, will review, tracking with waku-org/js-waku#327. |
Problem
Currently, libp2p only supports websockets and webrtc in the browser. We decided to start with websockets.
As nim-waku is the intended waku full node, browser client needs a way to connect to nim-waku nodes.
Additionally, as described in waku-org/js-waku#50, the websocket connections needs to be wrapped in TLS. As modern browsers simply block insecure websocket connection within an https page.
My understanding is that the intent of nim-waku is to be ran by the community to run a network. Thus, it should be consider how one can easily deployed nim-waku with wss enabled (certificate generation, etc).
Acceptance criteria
test fleet
References
The text was updated successfully, but these errors were encountered: