Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable websocket config in fleets #28

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Enable websocket config in fleets #28

merged 1 commit into from
Nov 17, 2021

Conversation

rshiv
Copy link
Contributor

@rshiv rshiv commented Nov 15, 2021 •
edited
Loading

This PR introduces the config changes required to enable secure web-sockets to resolve the issue waku-org/nwaku#434.

We add 4 configs to the nim-waku build in this PR.

  • websocket-secure-support
  • websocket-secure-key-path
  • websocket-secure-cert-path
  • websocket-port

@rshiv rshiv requested a review from jakubgs November 15, 2021 18:04
@rshiv
Copy link
Contributor Author

rshiv commented Nov 16, 2021

I have made the required changes as suggested , please let me know your thoughts about the same. @jakubgs

@rshiv rshiv requested a review from jakubgs November 17, 2021 10:21
@rshiv @jakubgs
nim-waku: add support for websocket flags
d10d0de 
Signed-off-by: rshiv <reeshav96@gmail.com>
Signed-off-by: Jakub Sokołowski <jakub@status.im>

fix typos, reuse variable values

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit 5dc3fe8 into master Nov 17, 2021
@jakubgs jakubgs deleted the enable_websockets branch November 17, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

@oskarth oskarth Awaiting requested review from oskarth

@jm-clius jm-clius Awaiting requested review from jm-clius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rshiv @jakubgs @jm-clius