Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archive): reverse the db query results in the waku archive front-end #1511

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Jan 25, 2023

This regression was introduced during the Waku archive and the Waku store code split. The Waku archive test did not cover the query chain responses. And the regression was not detected by the Status app since they only use the forward pagination.

  • Fixed the backwards pagination regression by moving the query result rows reordering step to the archive front-end.
  • Updated the test cases to cover this scenario.
  • Improved code readability of the findMessages Waku archive method.

This PR resolves #1502 regression.

@LNSD LNSD self-assigned this Jan 25, 2023
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great, thanks

@status-im-auto
Copy link
Collaborator

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
643602a #1 2023-01-25 23:10:20 ~23 min macos 📄log

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LNSD
Copy link
Contributor Author

LNSD commented Jan 26, 2023

All CI test failures are unrelated to the PR changes. All Waku archive tests are passing. Ubuntu CI jobs are passing.

I have re-run the jobs, but the tests keep failing. cc #1357

@LNSD LNSD merged commit 95d31b3 into master Jan 26, 2023
@LNSD LNSD deleted the fix-archive-backwards-pagination branch January 26, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Waku Store returns duplicate messages
5 participants