fix(node): remove subscription to waku default network topic (#1545) #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LNSD
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
alrevuelta
reviewed
Feb 10, 2023
|
Alright 😁 I just reviewed all tools and examples. It seems that all tools, apps and examples either explicitly subscribe to a topic or have the default pub-sub topic as the default value for the |
LNSD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the scaling initiative, requirements have changed. This PR removes the
wakunode2's implicit subscription to the default pub-sub topic. If the CLI argument is not specified, the node will subscribe to the default pub-sub topic./waku/2/default-waku/proto.This PR resolves #1545.