fix: allow higher resolution timestamps #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows higher precision
Timestamp
sWakurtosis reported that all timestamps logged by nwaku were in second resolution (no fractional seconds), which is too imprecise for testing latency, identifying messages etc.
It turns out that our
Timestamp
construction converted the more precisefloat
seconds (with fraction) toint64
before multiplying, resulting in the fractional part always being truncatedI've also:
Timestamp
should always be nanoseconds.SomeNumber
types in input.