-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rln-relay): use precompiled resources w/ rln #1578
Conversation
.gitmodules
Outdated
@@ -143,7 +143,7 @@ | |||
path = vendor/zerokit | |||
url = https://github.com/vacp2p/zerokit.git | |||
ignore = dirty | |||
branch = master | |||
branch = staticlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update this after zerokit's pr is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that you removed the experimental stage from the Dockerfile. That's a great improvement 👏🏼
There are some remainings in the Makefile
(e.g., these lines should be removed). Could you review the Makefile tasks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
will merge since zerokit's pr has been merged (after checks pass) |
Companion PR: vacp2p/zerokit#118
This pr loads rln as a static library, without the need for additional resources (verifier, prover etc). It is an incremental update, and the next pr will download the static lib from zerokit's nightly release directly(blocked at the moment).
can be merged after zerokit's pr is merged.