feat(rln-relay): use precompiled resources w/ rln #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
commented
Mar 3, 2023
.gitmodules
Outdated
| @@ -143,7 +143,7 @@ | |||
| path = vendor/zerokit | |||
| url = https://github.com/vacp2p/zerokit.git | |||
| ignore = dirty | |||
| branch = master | |||
| branch = staticlib | |||
There was a problem hiding this comment.
I'll update this after zerokit's pr is merged.
LNSD
suggested changes
Mar 3, 2023
There was a problem hiding this comment.
I noticed that you removed the experimental stage from the Dockerfile. That's a great improvement 👏🏼
There are some remainings in the Makefile (e.g., these lines should be removed). Could you review the Makefile tasks?
|
will merge since zerokit's pr has been merged (after checks pass) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: vacp2p/zerokit#118
This pr loads rln as a static library, without the need for additional resources (verifier, prover etc). It is an incremental update, and the next pr will download the static lib from zerokit's nightly release directly(blocked at the moment).
can be merged after zerokit's pr is merged.