Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add validator for dos protec metrics and move to app #1704

Merged
merged 2 commits into from
May 2, 2023
Merged

chore: add validator for dos protec metrics and move to app #1704

merged 2 commits into from
May 2, 2023

Conversation

alrevuelta
Copy link
Contributor

@alrevuelta alrevuelta commented Apr 24, 2023 •
edited
Loading

  • Add metrics for signed message validator see indicating amount of accepted and rejected messages.
  • Move said validator to app
  • Move tests to wakunode2 app tests.

Related: #1612

@alrevuelta alrevuelta added the blocked This issue is blocked by some other work label Apr 24, 2023
@alrevuelta alrevuelta marked this pull request as draft April 24, 2023 14:07
@alrevuelta alrevuelta mentioned this pull request May 2, 2023
Closed
4 tasks
@alrevuelta alrevuelta marked this pull request as ready for review May 2, 2023 10:14
@alrevuelta
Copy link
Contributor Author

Tests are failing, addressing the changes.

alrevuelta
alrevuelta commented May 2, 2023
View reviewed changes
tests/wakunode2/test_validators.nim
@@ -0,0 +1,265 @@
{.used.}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a copy paste of the tests, nothing changed

@alrevuelta
Copy link
Contributor Author

Fixed!

rymnc
rymnc approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jm-clius
jm-clius approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alrevuelta alrevuelta merged commit 3e14686 into master May 2, 2023
@alrevuelta alrevuelta deleted the rejected-msg-metrics branch May 2, 2023 14:20
@alrevuelta alrevuelta mentioned this pull request May 5, 2023
Open
9 tasks
@fryorcraken fryorcraken added the E:Opt-in message signing See https://github.com/waku-org/pm/issues/20 for details label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@jm-clius jm-clius jm-clius approved these changes

@vpavlin vpavlin Awaiting requested review from vpavlin

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees
No one assigned
Labels
blocked This issue is blocked by some other work E:Opt-in message signing See https://github.com/waku-org/pm/issues/20 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alrevuelta @rymnc @jm-clius @fryorcraken