chore(libp2p): Revert "chore(libp2p): update nim-libp2p" #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
changed the title
Ivansete-status
approved these changes
Jun 8, 2023
jm-clius
approved these changes
Jun 8, 2023
|
@Menduist Seems we cannot merge this as your commit is not signed |
Menduist
force-pushed
the
revert-1786-chore/update-libp2p
branch
from
7fa9bc5
to
a8eb646
Compare
This reverts commit 93e09b8.
|
TIL the "revert" button on github doesn't sign the commit, that's quite dumb :D |
vpavlin
force-pushed
the
revert-1786-chore/update-libp2p
branch
from
a8eb646
to
864661c
Compare
|
Damn, missed your force-push before doing a force-push to get it signed..sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1786
There is a regression in that nim-libp2p version causing constant nwaku crashes
Tracking regression here: vacp2p/nim-libp2p#910