test(store): Implement store tests (1/2) #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from eaa3c23 |
AlejandroCabeza
changed the base branch from
master
to
store-archive-utils-refactor
AlejandroCabeza
changed the title
AlejandroCabeza
force-pushed
the
store-archive-utils-refactor
branch
from
055b69c
to
ba2f9bb
Compare
AlejandroCabeza
force-pushed
the
test-store
branch
2 times, most recently
from
feb40f3
to
6bcab97
Compare
AlejandroCabeza
force-pushed
the
test-store
branch
from
6bcab97
to
a172987
Compare
gabrielmer
reviewed
Nov 29, 2023
Ivansete-status
requested changes
Nov 30, 2023
gabrielmer
reviewed
Nov 30, 2023
|
@Ivansete-status I see your point, and I don't really know what it should be. But I do see the usefulness in using 0 as meaning "give me everything" as the type is Maybe we should page an RFC guy? |
gabrielmer
approved these changes
Nov 30, 2023
AlejandroCabeza
force-pushed
the
test-store
branch
from
699ca20
to
7a796c2
Compare
AlejandroCabeza
changed the base branch from
master
to
history-query-ascending
Ivansete-status
approved these changes
Dec 1, 2023
AlejandroCabeza
force-pushed
the
history-query-ascending
branch
from
61d9e29
to
4b32cf4
Compare
AlejandroCabeza
force-pushed
the
test-store
branch
from
f56ceb4
to
fdc2486
Compare
AlejandroCabeza
force-pushed
the
history-query-ascending
branch
from
1ca30ae
to
01214b1
Compare
AlejandroCabeza
force-pushed
the
test-store
branch
from
fdc2486
to
c4f8834
Compare
AlejandroCabeza
force-pushed
the
test-store
branch
from
c4f8834
to
e20b308
Compare
* Implement remaining store tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement store tests
Changes