Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(peer-exchange): Implement peer exchange tests #2464

Merged
merged 14 commits into from
Mar 14, 2024
Merged

test(peer-exchange): Implement peer exchange tests #2464

merged 14 commits into from
Mar 14, 2024

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Feb 20, 2024 •
edited

Description

Implement peer exchange tests

Changes

  • Implement node-level peer exchange tests
  • Implement instance-level peer exchange negative-path tests
  • Fix a couple of type-related errors
  • Move existing peer exchange tests to the same module (as the other peer exchange tests)
  • Fix outdated relay tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2464-rln-v2-true

Built from 4bfac3c

Ivansete-status
Ivansete-status reviewed Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful PR! Thanks for it!
I'm not approving just yet because we need to clarify what has happened with the setPeerExchangePeer proc.

tests/node/test_wakunode_peer_exchange.nim Outdated Show resolved Hide resolved
tests/node/test_wakunode_peer_exchange.nim Outdated Show resolved Hide resolved
tests/node/test_wakunode_peer_exchange.nim Outdated Show resolved Hide resolved
tests/node/test_wakunode_peer_exchange.nim Show resolved Hide resolved
tests/node/test_wakunode_peer_exchange.nim Show resolved Hide resolved
tests/waku_peer_exchange/test_protocol.nim Outdated Show resolved Hide resolved
tests/waku_peer_exchange/utils.nim Outdated Show resolved Hide resolved
tests/waku_peer_exchange/utils.nim Outdated Show resolved Hide resolved
SionoiS
SionoiS reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but waiting on #2486

SionoiS
SionoiS approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but remove the formatting before merging.

Thank you!

tests/node/test_wakunode_peer_exchange.nim Outdated Show resolved Hide resolved
apps/wakunode2/app.nim Outdated Show resolved Hide resolved
waku/node/waku_node.nim Outdated Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza merged commit f436240 into master Mar 14, 2024
14 of 15 checks passed
@AlejandroCabeza AlejandroCabeza deleted the test-peer-exchange branch March 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlejandroCabeza @SionoiS @Ivansete-status