feat(wakunode): Resultify fetch peer exchange peers #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlejandroCabeza can we try again without the formatting changes plz? |
Ah, dammit, didn't realise 🤦♀️ Will do. |
AlejandroCabeza
force-pushed
the
resultify-fetch-peer-exchange-peers
branch
from
ad1418f
to
3596843
Compare
SionoiS
approved these changes
Feb 29, 2024
|
You can find the image built from this PR at Built from 78d147f |
5 tasks
Ivansete-status
requested changes
Mar 4, 2024
Ivansete-status
approved these changes
Mar 11, 2024
|
Hey @AlejandroCabeza ! |
Indeed, indeed. I'll have a look what's going on. |
AlejandroCabeza
force-pushed
the
test-peer-exchange
branch
from
55438a1
to
54ca8aa
Compare
AlejandroCabeza
force-pushed
the
resultify-fetch-peer-exchange-peers
branch
from
88e7617
to
c363431
Compare
AlejandroCabeza
added a commit
that referenced
this pull request
Mar 13, 2024
* Resultify Wakunode.fetchPeerExchangePeers
AlejandroCabeza
added a commit
that referenced
this pull request
Mar 14, 2024
* Implement peer exchange tests. * Refactor, and remove duplicated tests. * feat(wakunode): Resultify fetch peer exchange peers (#2486)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade return type of
Wakunode.fetchPeerExchangePeers.Feel free to suggest better
errorreturns.Changes
FuturetoFuture[Result[int, string]].