Makefile: change compilation and linking of libbrotli to optional (and off by default) #1379
Conversation
LeGEC
force-pushed
the
1378-makefile-opt-out-libbrotli
branch
from
f4ea154
to
9203b79
Compare
LeGEC
force-pushed
the
1378-makefile-opt-out-libbrotli
branch
from
9203b79
to
e6bcc48
Compare
LeGEC
changed the title
USE_LIBBROTLI=1 option
LeGEC
changed the title
USE_LIBBROTLI=1 optionnote: this is a breaking change on the Makefile :
if you need to support brotli in your builds, you now need to add
USE_BROTLI=1
in your build environment.
e.g: change:
make link_brotli
make pg_build
to the equivalent of:
export USE_BROTLI=1
make link_brotli
make pg_build
LeGEC
force-pushed
the
1378-makefile-opt-out-libbrotli
branch
from
e6bcc48
to
06a838b
Compare
|
I tried to update the workflow files (by mimicking places where Also : I tried updating docs/README.md , do review if the places where |
|
Well, apparently, I missed the mongodb tests : https://github.com/wal-g/wal-g/actions/runs/3481421063/jobs/5823020774#step:8:4982 |
|
I pushed a commit where I changed the tests for redis and mongodb : the tests are run using zstd instead of brotli. I would much rather not change those tests in this specific PR and confirm that the main change (e.g: set USE_BROTLI if you want to use brotli) still allow to run the tests that depend on brotli unmodified, but I fail to understand where I missed passing the Can someone have a second look at the modifications I committed, and point me to what step requires adding |
|
It's in the docker compose files you'd want to look at See #634 |
search for Dockerfiles that run 'make [some_walg_build_rule]' at docker build time, and set "ENV USE_BROTLI 1" in those Dockerfiles
LeGEC
force-pushed
the
1378-makefile-opt-out-libbrotli
branch
from
d878d5d
to
aa4a6a0
Compare
|
setting the env value in the relevant Docker files seems to do the job. |
serprex
dismissed
usernamedt’s stale review
feedback to name config USE_BROTLI was implemented
Database name
all databases -- affects libbrotli at build time
Pull request description
Describe what this PR fix
fixes #1378
add aNO_LIBBROTLIoption to opt out of libbrotli at build time.This PR has been modified to :
add a
USE_BROTLIoption in the Makefile to build and link libbrotlithis is a (arguably small) breaking change :
if you previously ran regular make commands :
and still need to support the brotli compression format (for retrocompatibility), you now need to set
USE_BROTLI=1at build time :or somehow set it in your build pipeline