Fix tests under GCC and MinGW #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took a fair bit of this in this commit to validate the MinGW support. If you want to merge or rebase, we can see what's left. |
Mixaill
force-pushed
the
gcc-fixes-v2
branch
2 times, most recently
from
336f8d0
to
0c3e083
Compare
|
@walbourn rebased, tested on Ubuntu/GCC 9 and Ubuntu/Clang 9 |
walbourn
reviewed
Mar 11, 2020
walbourn
reviewed
Mar 11, 2020
walbourn
reviewed
Mar 11, 2020
Mixaill
force-pushed
the
gcc-fixes-v2
branch
2 times, most recently
from
e0b51d3
to
b8add1f
Compare
|
@walbourn switched to |
it is already applied in the if(MSVC) section
it is required for _xgetbv()
_countof() is the MSVC extension
_aligned_malloc is supported only in the MSVCRT but MSVCRT does not support std::alligned_alloc()
- add defines for secure functions - rearrange includes to fix compilation error - add WINAPI-specific defines for non-Windows OS - add defines for calling conventions - do not include <tchar.h> and <intrin.h> on non-Windows OS
|
@walbourn rebased |
|
Finished up the changes you proposed in a slightly different form as well as adding ARM64 linux support in #11. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake: refactor and add GCC supportcpuid: removed unneeded includes, fix cpuid call for GCCext: removedwindows.hincludemath3: fix include filenames casingmath3: added lacking defines for non-Windows platformsmath3: replacerand()withXM_RAND()which max values is limited with0x8000(glibc version generates values up to INT32_MAX, which causes test failures with GCC)math3,shmath: replace functions like_fpclasswithstd::alternativesxdsp: replace_aligned_mallocwithXM_ALIGNED_MALLOC, which selects_aligned_mallocon MSVC andstd::aligned_allocon other toolsetsRequires microsoft/DirectXMath#86
Tested with