Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in healthysig and fieldworkanalysis_samara vignettes #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Omabekee
Copy link

Hi Chloe,

This is an attempt to resolve the errors occurring during the knitting of the healthysig.Rmd and fieldworldanalysis_samara.Rmd vignettes by correcting the code causing the issue.

In healthysig.Rmd vignette, I noticed that the error was coming from line 46 to 54, when I checked Study 562/ experiment 10 had no signatures. This is why I think this error occurred. As a result, I commented out lines 46 to 54 as well as lines 130 to 180 where the bugs0 and healthysig0 objects were used.

In fieldworldanalysis_samara.Rmd vignette, the error occurred at lines 71 - 76, where the 'getMostFrequentTaxa' function wasn't correctly used, decided to update it by inserting 'directions' instead.
Another error at line 223 was corrected by changing 'maxit = 24' to 'maxit = 70'.

The vignettes were successfully built after these changes were made. I'm open to your feedback and corrections.

…d fieldworldanalysis_samara.Rmd vignette by correcting the code causing the issue.
@lwaldron
Copy link
Member

@haoyanzh do you know why http://bugsigdb.org/Study_562, Experiment 10, has no signatures? @Omabekee I think we should try to fix this signature and/or the code in healthysig.Rmd to serve its original purpose rather than commenting out the code.

Sounds like you've fixed fieldworldanalysis_samara.Rmd though!

@Omabekee
Copy link
Author

Thank you so much for the feedback @lwaldron I've made an attempt to read through the paper, but I'm encountering difficulty in locating Experiment 10 within the study.

Could you please provide some guidance on where I can find Experiment 10 within the paper?

Here's the link: https://zenodo.org/records/7622129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants