Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use download.cbioportal.org mirror #22

Merged
merged 7 commits into from Jul 9, 2020
Merged

Use download.cbioportal.org mirror #22

merged 7 commits into from Jul 9, 2020

Conversation

inodb
Copy link
Collaborator

@inodb inodb commented Jul 8, 2020

This uses AWS S3 and is a lot faster. But would be nicer if the url was e.g. download.mirror.cbioportal.org but it wasn't that straightforward to set up with SSL. Might update later

@inodb inodb requested a review from LiNk-NY July 8, 2020 18:17
@LiNk-NY
Copy link
Contributor

LiNk-NY commented Jul 8, 2020

@inodb
This change is in a script that identifies the available studies. I can update the link or add options that allow the user to choose a particular URL address.

@inodb
Copy link
Collaborator Author

inodb commented Jul 8, 2020

@LiNk-NY ah good catch. Yeah either of those works. Thanks!

@inodb inodb closed this Jul 8, 2020
@LiNk-NY LiNk-NY reopened this Jul 8, 2020
@LiNk-NY
Copy link
Contributor

LiNk-NY commented Jul 8, 2020

I was going to take the PR and build on it. Thanks.

@LiNk-NY LiNk-NY merged commit 55e05ad into master Jul 9, 2020
@LiNk-NY LiNk-NY deleted the update-download-url branch July 9, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants