formatting #735
Merged
formatting #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowangjuanzi
commented
Mar 24, 2022
| @@ -1462,9 +1459,6 @@ protected static function forkOneWorkerForLinux(self $worker) | |||
| { | |||
| // Get available worker id. | |||
| $id = static::getId($worker->workerId, 0); | |||
| if ($id === false) { | |||
There was a problem hiding this comment.
because $id's return type is int. so $id === false is never equal.
mowangjuanzi
commented
Mar 24, 2022
| @@ -1373,7 +1370,7 @@ protected static function forkWorkersForWindows() | |||
| } | |||
| else | |||
| { | |||
| static::$globalEvent = new \Workerman\Events\Select(); | |||
There was a problem hiding this comment.
because there is use at the top of the file
mowangjuanzi
commented
Mar 24, 2022
| @@ -1047,7 +1044,7 @@ protected static function formatStatusData($statistics_file) | |||
| $total_timers = 0; | |||
| $maxLen1 = static::$_maxSocketNameLength; | |||
| $maxLen2 = static::$_maxWorkerNameLength; | |||
| foreach($info as $key => $value) { | |||
There was a problem hiding this comment.
$key is not used.
mowangjuanzi
commented
Mar 24, 2022
| @@ -1003,9 +1002,7 @@ protected static function parseCommand() | |||
| \posix_kill($master_pid, $sig); | |||
| exit; | |||
| default : | |||
| if (isset($command)) { | |||
There was a problem hiding this comment.
$command never is null. because line 886.
mowangjuanzi
commented
Mar 24, 2022
| @@ -972,7 +971,7 @@ protected static function parseCommand() | |||
| $start_time = \time(); | |||
| // Check master process is still alive? | |||
| while (1) { | |||
| $master_is_alive = $master_pid && \posix_kill((int) $master_pid, 0); | |||
There was a problem hiding this comment.
$master_pid is already int
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to phpstorm prompt