Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 – Remove user reference in Tag entry ? #1543

Closed
j0k3r opened this issue Dec 29, 2015 · 2 comments
Closed

v2 – Remove user reference in Tag entry ? #1543

j0k3r opened this issue Dec 29, 2015 · 2 comments
Milestone

Comments

@j0k3r
Copy link
Member

j0k3r commented Dec 29, 2015

Since we've added a slug in the Tag entry which is unique, we got awful slug when user use the same tag label.

Here is an example with some fixtures:

id user_id label slug
1 2 foo foo
2 2 bar bar
3 1 foo foo-1
4 1 bar bar-1

As you can see, we got foo-1 as slug, it can goes pretty far, since we can then have foo-4893 for a slug. I don't really that.

That's why I'm wondering if we can remove the user assignation in that entry.

  1. If we need to retrieve all tags for a user, we can join over Entry & EntryTag to retrieve them
  2. We will have unique slug with a cleaner value
  3. Removing a tag for user will only have to remove lines in EntryTag

What do you think?

@j0k3r j0k3r added this to the 2.0.0-alpha.1 milestone Dec 29, 2015
@nicosomb
Copy link
Member

👍

@bdunogier
Copy link
Contributor

I don't have much perspective on this, but it does make sense to deduplicate things here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants