v2 – Remove user reference in tag #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameters are `star` & `archived`, not `is_starred` & `is_archived`
- WallabagRestController: remove the tag deletion from the API since we can't remove a tag now, we only remove reference to entries - RuleBasedTaggerTest: remove workaround for asserting tag are equal since problem was related to mock expects (_call instead of findOneByLabel which was removed from the tag repository)
| @@ -175,8 +174,8 @@ public function patchEntriesAction(Entry $entry, Request $request) | |||
| $this->validateUserAccess($entry->getUser()->getId()); | |||
|
|
|||
| $title = $request->request->get('title'); | |||
| $isArchived = $request->request->get('is_archived'); | |||
| $isStarred = $request->request->get('is_starred'); | |||
| $isArchived = $request->request->get('archive'); | |||
There was a problem hiding this comment.
oh, well done. this bug is here since a long time...
And move the SQL query inside the php doc
nicosomb
added a commit
that referenced
this pull request
Jan 2, 2016
v2 – Remove user reference in tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1543