Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update js & css assets #2249

Closed
tcitworld opened this issue Aug 28, 2016 · 5 comments
Closed

Update js & css assets #2249

tcitworld opened this issue Aug 28, 2016 · 5 comments
Assignees
@tcitworld
Labels
Improvement
Milestone
2.1.1

Comments

@tcitworld
Copy link
Member

There has some changes in css and js files lately. This has to be changed too in 2.1.
@tcitworld tcitworld added this to the 2.1.0 milestone Aug 28, 2016
@tcitworld tcitworld self-assigned this Aug 28, 2016
@j0k3r
Copy link
Member

j0k3r commented Aug 28, 2016

As far as I know, I fixed most of them when fighting against the bad rebase on the 2.1 branch.
But yeah, could be a good idea to check before the release.

@tcitworld
Copy link
Member Author

Also, add linters to the build assets travis task (and Grunt watch).

@j0k3r j0k3r mentioned this issue Aug 30, 2016
Merged
@tcitworld tcitworld mentioned this issue Sep 28, 2016
Merged
@j0k3r
Copy link
Member

j0k3r commented Oct 3, 2016

There is still (from #2314 (comment))

  • Fix for twitter icons becoming facebook one (WTF ?)

@nicosomb
Copy link
Member

nicosomb commented Oct 3, 2016

Done 👍
Good job with the front part, @tcitworld <3

@nicosomb nicosomb closed this as completed Oct 3, 2016
@j0k3r j0k3r modified the milestones: 2.1.1, 2.1.0 Oct 3, 2016
@j0k3r j0k3r reopened this Oct 3, 2016
@j0k3r j0k3r changed the title Update js & css assets before 2.1 Update js & css assets Oct 3, 2016
@nicosomb nicosomb modified the milestones: 2.1.1, 2.1.2 Oct 3, 2016
@j0k3r
Copy link
Member

j0k3r commented Oct 4, 2016

Fixed here #2353

@j0k3r j0k3r modified the milestones: 2.1.2, 2.1.1 Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcitworld tcitworld

Labels
Improvement
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
3 participants
@j0k3r @nicosomb @tcitworld