Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assets work #2314

Merged
merged 6 commits into from
Oct 3, 2016
Merged

Assets work #2314

merged 6 commits into from
Oct 3, 2016

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Sep 28, 2016 •
edited

Q A
Bug fix? yes and no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets #2231, #2249
License MIT

@tcitworld
Assets work
c146f69 
* ES6 all the things !

* ESLint checks everything

* CSS fixes (use stylelint)

* Fix #2231
@tcitworld tcitworld added this to the 2.1.0 milestone Sep 28, 2016
@tcitworld
Copy link
Member Author

Please test many use cases. :-)

nicosomb
nicosomb requested changes Sep 28, 2016
View reviewed changes
.gitignore
@@ -49,3 +49,7 @@ app/Resources/static/lib/*
/bin
!/src/Wallabag/CoreBundle/Resources/public
/src/Wallabag/CoreBundle/Resources/public/*

# PHPStorm
.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to put these lines in a global gitignore

j0k3r
j0k3r requested changes Sep 28, 2016
View reviewed changes
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks the filter panel on baggy:
image

@tcitworld
Copy link
Member Author

@j0k3r I can't reproduce. Did you forgot to run grunt after checkout ?

@j0k3r
Copy link
Member

j0k3r commented Sep 28, 2016

Ok it works again, maybe I forgot to run grunt.

Anyway,

  • the panel can't be close
  • clear works great

@tcitworld
Copy link
Member Author

the panel can't be close

I can on my side. Maybe clear wallabag & browser cache ?

@j0k3r
Copy link
Member

j0k3r commented Sep 28, 2016

I still can't.
Could you point where is the function which should close it?

@tcitworld
Copy link
Member Author

It should be https://github.com/wallabag/wallabag/pull/2314/files#diff-b6cebb35827533b53fb7f26090c13f6bR254

@tcitworld
Copy link
Member Author

tcitworld commented Sep 28, 2016 •
edited

@j0k3r Should work now.

  • Font ligatures are not working
  • Rewrite font paths from bower to npm

@j0k3r
Copy link
Member

j0k3r commented Sep 28, 2016 •
edited

Yep it works!
So we can ditch bower? 😆

@tcitworld
Copy link
Member Author

  • Fix for twitter icons becoming facebook one (WTF ?)

j0k3r
j0k3r reviewed Sep 29, 2016
View reviewed changes
package.json
@@ -10,6 +10,8 @@
"dependencies": {
"annotator": "git://github.com/wallabag/annotator.git#0f076c7d371ed25eb0793346f46982d90f2c4c85",
"autoprefixer": "^6.3.6",
"babel-preset-es2015": "^6.14.0",
"babelify": "^7.3.0",
"bower": "^1.7.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed too

@nicosomb
Copy link
Member

nicosomb commented Oct 3, 2016

👍

@nicosomb nicosomb merged commit ab809de into 2.1 Oct 3, 2016
@nicosomb nicosomb deleted the assets branch October 3, 2016 07:09
@j0k3r j0k3r mentioned this pull request Oct 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r requested changes

@nicosomb nicosomb nicosomb requested changes

Assignees

@j0k3r j0k3r

@nicosomb nicosomb

Labels
Ready for review UI
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tcitworld @j0k3r @nicosomb