Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed last merge who caused CSS/JS bugs #2252

Merged
merged 2 commits into from
Sep 2, 2016
Merged

Fixed last merge who caused CSS/JS bugs #2252

merged 2 commits into from
Sep 2, 2016

Conversation

nicosomb
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documentation no
Translation no
Fixed tickets
License MIT

Last merge from master to 2.1 was buggy.
I just need help, because jquery.tinydot from @modos189 doesn't seem to be loaded.

Help needed @modos189 @tcitworld @j0k3r :)

@nicosomb nicosomb added this to the 2.1.0 milestone Aug 30, 2016
@tcitworld tcitworld self-assigned this Aug 30, 2016
@j0k3r
Copy link
Member

j0k3r commented Aug 30, 2016

My bad if it was buggy. Mostly because stuff has to be done to include new lib in package.json as soon as they are added in the master branch.
And this PR is related to #2249

@nicosomb
Copy link
Member Author

@j0k3r not a problem 😗

@j0k3r
Copy link
Member

j0k3r commented Sep 2, 2016

jquery.tinydot is now loaded for material.

@tcitworld
Copy link
Member

Instead of concating jquery.tinydot, require it through browserify in the main js file.

@nicosomb
Copy link
Member Author

nicosomb commented Sep 2, 2016

👍

@nicosomb
Copy link
Member Author

nicosomb commented Sep 2, 2016

Instead of concating jquery.tinydot, require it through browserify in the main js file.

@tcitworld why?

@tcitworld
Copy link
Member

Because I find it better to use js modules instead of just concat all code. Moreover, minification should be better.

@j0k3r
Copy link
Member

j0k3r commented Sep 2, 2016

@tcitworld tried both require('tinydot');

Error: Cannot find module 'jQuery' from '/home/jeremy/github/wallabag/node_modules/jquery.tinydot/src'

require('jquery.tinydot');

Error: Cannot find module 'tinydot' from '/home/jeremy/github/wallabag/web/bundles/wallabagcore'

Without success.

@j0k3r
Copy link
Member

j0k3r commented Sep 2, 2016

It looks too complex to load a jquery plugin with requirejs...
I think we'll keep it like this. I'll switch to the non minified version instead.

@nicosomb nicosomb merged commit 336262e into 2.1 Sep 2, 2016
@nicosomb nicosomb deleted the fix-last-merge branch September 2, 2016 08:27
@tcitworld
Copy link
Member

It looks too complex to load a jquery plugin with requirejs...

I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants