Add RSS feeds #1166
Merged
Add RSS feeds #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% trans %}estimated reading time :{% endtrans %} < 1 min | ||
| {%- endif %} | ||
|
|
||
| {{ entry.content -}} |
There was a problem hiding this comment.
To keep html content? Well I've encaplusated the content inside a CDATA to avoid problem.
But yes, I need to test with raw.
There was a problem hiding this comment.
I tryied, and I think it doesn't work.
will fix #1000
Since it's the primary key
They are god damn too long to execute because it launch external command (mostly related to doctrine). So I've added a PHPUnit @group (`command-doctrine`) so that we can avoid launching them on a regular basis, like that: `phpunit --exclude-group command-doctrine`
Mailjet seems to be laggy, hope that LeMonde will be more reliable in the future. @see https://travis-ci.org/wallabag/wallabag/jobs/56246231
We don't want Symfony to escape html content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, items in each feeds are limited to 50. User can change this value in the config page. This will fix #1000.
I've re-added the token system (I put it in a
Tools/Utilsclass), which can also be regenerated (todo: make an ajax call).Url are like that:
http://wallabag.io/j0k3r/0jlmUxAVZqmc26P/unread.xmlI've added a ParamConverter to check if the username and the token in the url are good.
I've also added an
@Assert\RangeonitemPerPage&rssLimitto be sure it's a number. So the validation works on the form too. I've put a kind of random number as max value: 100.000.Regarding the
InstallCommandtests, they are god damn too long to execute because it launch external commands (mostly related to doctrine).So I've added a PHPUnit @group (
command-doctrine) so that we can avoid launching them on a regular basis, like that:And I've update travis to run PHPUnit like that for the moment. Launching
phpunitwill still work, but it's longer. The downside is that theInstallCommandis less tested using--exclude-group